chore: use workspace protocol for internal dependencies#3209
chore: use workspace protocol for internal dependencies#3209lariciamota merged 3 commits intodevfrom
Conversation
WalkthroughReplaced semver dependency specifiers with workspace protocol references in two package.json files, switching Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace hardcoded version references with workspace:* protocol for @faststore/components and @faststore/ui in packages/ui and packages/storybook to ensure local packages are always resolved from the monorepo workspace. Co-authored-by: Cursor <cursoragent@cursor.com>
b84c030 to
2d9ce45
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/ui/package.json`:
- Line 57: Update the peerDependencies entry for the package so it uses
workspace:^ instead of workspace:*, specifically change the
"@faststore/components" peerDependency from "workspace:*" to "workspace:^" so
the published range becomes a caret range (e.g., ^3.97.0-dev.2) and preserves
version flexibility for downstream consumers.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/ui/package.json`:
- Around line 56-58: The peerDependencies block in packages/ui/package.json
dropped the `@faststore/components` peer contract unexpectedly; restore the peer
contract by re-adding "@faststore/components" to the "peerDependencies" object
using the workspace spec that preserves a 3.x range (e.g., "workspace:^" so it
publishes as ^3.x.y) if you intend to keep the compatibility signal, or if
removal was intentional, update the PR description to state that
`@faststore/components` was deliberately removed; edit the package.json's
"peerDependencies" entry for `@faststore/components` or the PR description
accordingly.
🧹 Nitpick comments (1)
packages/ui/package.json (1)
50-50:workspace:*publishes as an exact version — verify this is intentional.The original specifier
^3.97.0-dev.2allowed compatible updates, whileworkspace:*will resolve to an exact pinned version on publish (e.g.,3.97.0-dev.2). Since these packages are released in lockstep from the monorepo this is likely fine, but if you want to preserve caret-range semantics for published consumers, useworkspace:^instead.
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@packages/ui/package.json`:
- Around line 56-60: The peerDependencies entry for "@faststore/components" uses
"workspace:*", which will be published as an exact version and break semver
ranges; update the peerDependencies object to use "workspace:^" for
"@faststore/components" instead so published manifests keep a caret range (e.g.,
workspace:^) and preserve compatibility with other 3.x releases.
Summary
^3.97.0-dev.2) withworkspace:*protocol for@faststore/componentsand@faststore/uiinpackages/ui/package.jsonandpackages/storybook/package.jsonMotivation
Extracted from PR #3117 as requested in code review by @lariciamota, so we can identify possible problems easier by isolating this change.
Changed files
packages/ui/package.json—@faststore/componentsdependency and peerDependency changed toworkspace:*packages/storybook/package.json—@faststore/componentsand@faststore/uidependencies changed toworkspace:*Summary by CodeRabbit