fix(types): support chain call#8595
Merged
Conversation
fix:use feat continuous operation
fix:mixin feat continuous operation
ktsn
reviewed
Aug 3, 2018
Member
ktsn
left a comment
ktsn
left a comment
There was a problem hiding this comment.
Can we add a test case for types?
Member
|
What do you mean? I actually did request you to add some test case in here to confirm that this type annotation is correct. |
Contributor
Author
|
Yes, I can add. |
added 2 commits
August 3, 2018 20:01
ktsn
reviewed
Aug 4, 2018
| .use(() => { | ||
|
|
||
| }) | ||
| .mixin({}); |
Member
There was a problem hiding this comment.
This only checks return type of use. We also need to check return type of mixin.
ktsn
reviewed
Aug 4, 2018
|
|
||
| // #8595 | ||
| it('chain call', () => { | ||
| expect(Vue.mixin({}).toBe(Vue)) |
Member
There was a problem hiding this comment.
Looks like a typo.
expect(Vue.mixin({})).toBe(Vue)
Contributor
Author
|
All test add done. |
ktsn
approved these changes
Aug 4, 2018
chillcaw
approved these changes
Sep 9, 2018
chillcaw
left a comment
chillcaw
left a comment
There was a problem hiding this comment.
Changes and the added test look solid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: