Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new WASIX regression tests around FD_CLOEXEC behavior on pipes (notably pipe2(O_CLOEXEC)) and adds a popen-focused reproduction to catch stdin/EOF hangs caused by leaked pipe FDs across exec/spawn.
Changes:
- Add a new
tests/wasix/popentest case that exercisesvforkvspopenbehavior when writing to a child’s stdin. - Extend the existing
tests/wasix/cloexectest to include apipe2(O_CLOEXEC)flag verification. - Update
cloexec/run.shto add timeouts and run the new test entrypoint.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/wasix/popen/run.sh | Builds and runs the new popen/vfork regression scenarios under timeouts. |
| tests/wasix/popen/main.c | Implements combined echo/shell/vfork/popen test binary, including a popen-like implementation. |
| tests/wasix/popen/.no-build | Switches popen test directory to self-build via run.sh. |
| tests/wasix/cloexec/run.sh | Adds timeouts and runs the new pipe2_cloexec_test entrypoint (also recompiles). |
| tests/wasix/cloexec/main.c | Adds a new pipe2_cloexec_test subcommand to assert FD_CLOEXEC is set. |
Contributor
Author
|
Marked as draft until wasix-org/wasix-libc#99 is merged |
Contributor
The PR got merged, can we rebase the tests now? |
038cf1a to
aef451b
Compare
aef451b to
36e84d8
Compare
marxin
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds wasix tests for
CLOEXECon pipes. It also adds tests around popen, because that was where I was encountering these issues.The tests will pass after wasix-org/wasix-libc#99 is merged