fix: relax parsing of --volume argument with respect to Windows#6202
Merged
fix: relax parsing of --volume argument with respect to Windows#6202
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows path parsing for the --volume argument by switching from split(":") to rsplit_once(":"). The original issue was that Windows paths like C:\Users\...:app would incorrectly split into three components due to the colon in C:\, causing parsing to fail. The fix enables the Windows CI tests that were previously excluded due to this bug.
Changes:
- Replace
split(":").collect_vec()withrsplit_once(":")inparse_volumeandparse_mapdirfunctions to handle Windows drive letters - Remove the
itertools::Itertoolsimport that is no longer needed - Re-enable Windows integration tests in the CI workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/cli/src/utils/mod.rs | Updated parsing logic for volume and mapdir arguments to use rsplit_once instead of split, fixing Windows path support |
| .github/workflows/test.yaml | Removed Windows exclusion from test-integration-cli-ci tests now that the parsing bug is fixed |
syrusakbary
approved these changes
Feb 16, 2026
marxin
force-pushed
the
cli-volume-arg-windows
branch
from
00e2391 to
59520b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us running the CLI integrations tests on Windows as well!
Fixes: #6191