-
Notifications
You must be signed in to change notification settings - Fork 4
Switch default cluster to ES7 #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bug: T415664
tarrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's just a WIP but here's my thoughts:
- let's go ahead and remove all the ES6 stuff
- the actual ES6 deployment
- the special ES6 transport
- any ES6 related environment variables
- resolve any code that had special behaviour when those variables were set
- remove from the docs any references to ES6
docker-compose.yml
Outdated
| - MW_WRITE_ONLY_ELASTICSEARCH_HOST=elasticsearch-7.svc | ||
| - MW_WRITE_ONLY_ELASTICSEARCH_PORT=9200 | ||
| - MW_WRITE_ONLY_ELASTICSEARCH_ES6=false | ||
| - MW_DEFAULT_ELASTICSEARCH_ES6=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this line remains? I thought this PR was removing ES6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah can you test it? Whenever I remove it, everything goes "kaputt"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried commenting out MW_DEFAULT_ELASTICSEARCH_ES6 and followed the instructions in https://github.com/wbstack/mediawiki/pull/525/changes. The first time didn't seem to work, but after throwing everything away (docker compose down --volumes) and trying again I was able to successfully create some items and do a case-insensitive search for them. The output at http://localhost:9200/mwdb_somedb1_content_first/_search also looked sensible.
Have you tried recreating your local set-up? What specifically is "kaputt"?
Bug: T415664