Skip to content

Refactor: Use Encryptable concern in CoinbaseItem#1339

Merged
jjmata merged 2 commits into
we-promise:mainfrom
boul2gom:coinbase-encryptable-duplication
Apr 7, 2026
Merged

Refactor: Use Encryptable concern in CoinbaseItem#1339
jjmata merged 2 commits into
we-promise:mainfrom
boul2gom:coinbase-encryptable-duplication

Conversation

@boul2gom

@boul2gom boul2gom commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Remove the duplicated encryption_ready? method in favor of the Encryptable concern which provides the exact same functionality.

Summary by CodeRabbit

  • Refactor
    • Consolidated encryption configuration by moving credential encryption setup to a shared module, improving code maintainability and consistency across the application.

boul2gom added 2 commits April 1, 2026 16:48
Remove the duplicated encryption_ready? method in favor of the Encryptable concern which provides the exact same functionality.
@coderabbitai

coderabbitai Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f9d022d3-8b73-4e17-8da7-8a5962557988

📥 Commits

Reviewing files that changed from the base of the PR and between 43d6176 and acd778d.

📒 Files selected for processing (1)
  • app/models/coinbase_item.rb

📝 Walkthrough

Walkthrough

The CoinbaseItem model refactors its encryption configuration by replacing a local self.encryption_ready? method with the shared Encryptable module. The encryption setup logic remains unchanged, but responsibility for determining readiness is delegated to the module.

Changes

Cohort / File(s) Summary
Encryptable Module Integration
app/models/coinbase_item.rb
Removed local encryption_ready? method and included Encryptable module to centralize encryption readiness logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through clean code today,
Module extracted, the local method away!
Encryptable holds the truth we need,
Less duplication—a refactored deed! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: refactoring CoinbaseItem to use the Encryptable concern instead of a local implementation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jjmata jjmata merged commit d3469a9 into we-promise:main Apr 7, 2026
7 checks passed
@boul2gom boul2gom deleted the coinbase-encryptable-duplication branch April 11, 2026 07:57
binarygituser referenced this pull request in binarygituser/sure-dev Apr 26, 2026
Remove the duplicated encryption_ready? method in favor of the Encryptable concern which provides the exact same functionality.
jaxver pushed a commit to jaxver/sure that referenced this pull request May 31, 2026
Remove the duplicated encryption_ready? method in favor of the Encryptable concern which provides the exact same functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants