Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
This commit enables the configuration of the mcp service directly in the values.yaml, by passing in yaml format whatever tools with descrption we might want to override.
jfrancoa
added a commit
to weaviate/weaviate-local-k8s
that referenced
this pull request
Feb 11, 2026
NOTE: This PR depends on weaviate/weaviate-helm#321 Add a new option in weaviate-local-k8s to start up the MCP server. It only allows enabling the MCP service, but other values can be overriden via the values-override.yaml. The MCP server will get exposed in the port 9900 by default.
Aligns with weaviate/weaviate#10847 which moves the MCP server from a dedicated port (9000) onto the main REST API at /v1/mcp. This removes the separate MCP service, MCP_SERVER_PORT env var, and MCP container port since MCP now inherits the existing REST port. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove separate MCP port in favor of REST endpoint /v1/mcp
Simplify the values key from `mcpService` to `mcp` since MCP is now served on the main REST port (/v1/mcp) and no longer needs a separate Kubernetes Service. Also add a `default false` fallback for writeAccessEnabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds opt-in Helm configuration to enable and customize Weaviate’s MCP (Model Context Protocol) server, including wiring the necessary env vars and optional ConfigMap-based tool description configuration.
Changes:
- Introduces
mcpsettings invalues.yaml(disabled by default; optional write access and tool config). - Injects MCP-related env vars and mounts an MCP ConfigMap into the StatefulSet when configured.
- Adds a new Helm template for the MCP ConfigMap and extends CI Helm-render tests to cover the new behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
weaviate/values.yaml |
Adds user-facing mcp configuration block and examples. |
weaviate/templates/weaviateStatefulset.yaml |
Conditionally sets MCP env vars and mounts the MCP config volume. |
weaviate/templates/weaviateMCPConfig.yaml |
Creates a ConfigMap for MCP tool configuration when provided. |
.cicd/test.sh |
Adds Helm template assertions for MCP enablement and config mounting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jfrancoa
approved these changes
Apr 13, 2026
jfrancoa
added a commit
to weaviate/weaviate-local-k8s
that referenced
this pull request
Apr 13, 2026
NOTE: This PR depends on weaviate/weaviate-helm#321 Add a new option in weaviate-local-k8s to start up the MCP server. It only allows enabling the MCP service, but other values can be overriden via the values-override.yaml. The MCP server will get exposed in the port 9900 by default.
jfrancoa
added a commit
to weaviate/weaviate-local-k8s
that referenced
this pull request
Apr 13, 2026
NOTE: This PR depends on weaviate/weaviate-helm#321 Add a new option in weaviate-local-k8s to start up the MCP server. It only allows enabling the MCP service, but other values can be overriden via the values-override.yaml. The MCP server will get exposed in the port 9900 by default.
jfrancoa
added a commit
to weaviate/weaviate-local-k8s
that referenced
this pull request
Apr 13, 2026
NOTE: This PR depends on weaviate/weaviate-helm#321 Add a new option in weaviate-local-k8s to start up the MCP server. It only allows enabling the MCP service, but other values can be overriden via the values-override.yaml. The MCP server will get exposed in the port 9900 by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
mcpsection tovalues.yamlthat controls MCP (Model Context Protocol) server configuration, disabled by default/v1/mcp— no separate Kubernetes Service or port is neededMCP_SERVER_ENABLED,MCP_SERVER_WRITE_ACCESS_ENABLED, andMCP_SERVER_CONFIG_PATHenvironment variables into the StatefulSet when MCP is enabledweaviateMCPConfig.yaml) that auto-creates and mounts custom MCP tool descriptions whenmcp.configis set.cicd/test.shConfiguration
Security
writeAccessEnabled: false)