fix: throw specific exception on empty list filters for time filters#2004
Open
Maanik23 wants to merge 1 commit intoweaviate:mainfrom
Open
fix: throw specific exception on empty list filters for time filters#2004Maanik23 wants to merge 1 commit intoweaviate:mainfrom
Maanik23 wants to merge 1 commit intoweaviate:mainfrom
Conversation
The _FilterByTime class (used by by_creation_time and by_update_time) was missing the empty list validation that other filter classes already have. Calling contains_any([]) or contains_none([]) on a time filter would silently produce a malformed filter rather than raising a clear error. Added the same WeaviateInvalidInputError check used by _FilterByProperty and _FilterById, plus tests for both contains_any and contains_none on both creation_time and update_time filters. Fixes weaviate#933
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I have read and agree to the Weaviate Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #933
Summary
The
_FilterByTimeclass (used byby_creation_time()andby_update_time()) was missing the empty list validation that other filter classes already have. Callingcontains_any([])orcontains_none([])on a time filter would silently produce a malformed filter instead of raising a clear error.This brings
_FilterByTimein line with_FilterByPropertyand_FilterById, which already raise `WeaviateInvalidInputError` for empty input.Changes
`weaviate/collections/classes/filters.py`
`test/collection/test_filter.py`
Why this matters
Without these checks, code like:
```python
collection.query.fetch_objects(
filters=Filter.by_creation_time().contains_any([])
)
```
would either crash with an opaque `IndexError` deep in the gRPC layer or send a malformed filter to the server. After this PR it raises a clear `WeaviateInvalidInputError` at construction time, matching the existing UX for property and ID filters.
Test plan