Skip to content

Fix test failures on main#2005

Open
dirkkul wants to merge 4 commits intomainfrom
fix_async_test
Open

Fix test failures on main#2005
dirkkul wants to merge 4 commits intomainfrom
fix_async_test

Conversation

@dirkkul
Copy link
Copy Markdown
Collaborator

@dirkkul dirkkul commented Apr 8, 2026

  • Skip async replication test for old version
  • Fix async replicaiton worker tests
  • delete flaky lazy shard loading test (already deleted in dev/v1.37)
  • update to latest versions

Copilot AI review requested due to automatic review settings April 8, 2026 17:34
Copy link
Copy Markdown

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an integration test to be version-aware by skipping async replication configuration validation on Weaviate versions that don’t support it.

Changes:

  • Add a Weaviate version gate to test_replication_config_with_async_config to skip on versions < 1.34.18.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.87%. Comparing base (ccf4f61) to head (a44ad58).
⚠️ Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
integration/test_collection_config.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
+ Coverage   87.84%   87.87%   +0.03%     
==========================================
  Files         280      280              
  Lines       21347    21655     +308     
==========================================
+ Hits        18752    19030     +278     
- Misses       2595     2625      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkkul dirkkul requested a review from a team as a code owner April 8, 2026 17:53
@dirkkul dirkkul changed the title Skip async replication test for old version Fix test failures on main Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants