fix(shared): move zod from devDependencies to dependencies#2065
Merged
Conversation
zod is imported at runtime in mcp/tool-generator.ts but was only listed as a devDependency. This causes "Cannot find module 'zod'" when @midscene/web is installed via npx (which doesn't install devDeps).
Deploying midscene with
|
| Latest commit: |
1b146f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8aace25.midscene.pages.dev |
| Branch Preview URL: | https://fix-shared-zod-dependency.midscene.pages.dev |
…recorder scroll listener - Add destroy() override in WebPuppeteerMidsceneTools to disconnect browser on cleanup - Format scroll event listener options in recorder
EAGzzyCSL
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zodfromdevDependenciestodependenciesin@midscene/sharedzodis imported at runtime inmcp/tool-generator.tsbut was only listed as a devDependencyCannot find module 'zod'error when@midscene/webis installed vianpx(which doesn't install devDeps)destroy()override inWebPuppeteerMidsceneToolsto disconnect the browser on cleanupTest plan
npx @midscene/web connect --url "https://baidu.com"to verify zod is resolved correctly