add url host test: Port number is removed if new port is scheme default #10892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ah, we do have "Default port number is removed" tests, but they do not have a non-default port themselves (at least the host setter variants). |
Member
|
Could you maybe locate this test closer to those and indicate how it's different from them? I think that'd make things easier for maintainers. |
3 tasks
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
May 8, 2018
Includes web-platform-tests/wpt#10892, which we pass.
AyushG3112
added a commit
to AyushG3112/node
that referenced
this pull request
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test for a bug found with the
node.jsimplementation of URL, which was not covered by the existing test cases.Refs: nodejs/node#20479