Implement failure tests cases for the EC import operation#48243
Merged
twiss merged 1 commit intoweb-platform-tests:masterfrom Sep 23, 2024
Merged
Implement failure tests cases for the EC import operation#48243twiss merged 1 commit intoweb-platform-tests:masterfrom
twiss merged 1 commit intoweb-platform-tests:masterfrom
Conversation
javifernandez
force-pushed
the
ec-import-failures
branch
from
4b812d9 to
bada6d7
Compare
twiss
reviewed
Sep 18, 2024
javifernandez
force-pushed
the
ec-import-failures
branch
from
bada6d7 to
6416238
Compare
Frosne
reviewed
Sep 19, 2024
Frosne
reviewed
Sep 19, 2024
Frosne
reviewed
Sep 19, 2024
javifernandez
force-pushed
the
ec-import-failures
branch
from
6416238 to
acf3e41
Compare
Frosne
approved these changes
Sep 19, 2024
WebCryptoAPI/import_export/ec_importKey_failures_ECDH.https.any.js
Outdated
Show resolved
Hide resolved
javifernandez
force-pushed
the
ec-import-failures
branch
3 times, most recently
from
e340c93 to
b2dc94c
Compare
Frosne
approved these changes
Sep 20, 2024
| return missingJWKFieldKeyData["P-521"]; | ||
| } | ||
|
|
||
| function getInvalidJWKKeyData(algorithm) { |
Contributor
There was a problem hiding this comment.
this function is only for the keys where the public key does not correspond to the private key?
I would prefer a more specific name maybe?
mozkeeler
reviewed
Sep 20, 2024
javifernandez
force-pushed
the
ec-import-failures
branch
from
b2dc94c to
db40770
Compare
javifernandez
force-pushed
the
ec-import-failures
branch
from
db40770 to
edba641
Compare
panva
suggested changes
Sep 23, 2024
Contributor
There was a problem hiding this comment.
missingJWKFieldKeyData is not defined for ECDSA and ECDH tests, the harness fails
- https://wpt.fyi/results/WebCryptoAPI/import_export/ec_importKey_failures_ECDSA.https.any.html?diff&filter=ADC&run_id=4867596877037568&run_id=5151923644923904
- https://wpt.fyi/results/WebCryptoAPI/import_export/ec_importKey_failures_ECDH.https.any.html?diff&filter=ADC&run_id=4867596877037568&run_id=5151923644923904
This PR implements new tests for the import operation of ECDH and ECDSA algorithms, defining failure test cases. Additionally, it applies some refactoring to the code already used for OPK keys.
javifernandez
force-pushed
the
ec-import-failures
branch
from
edba641 to
ecbdbcb
Compare
Contributor
Author
Fixed ! |
mozkeeler
approved these changes
Sep 23, 2024
Contributor
mozkeeler
left a comment
mozkeeler
left a comment
There was a problem hiding this comment.
FWIW, the issue I noted was addressed.
Frosne
approved these changes
Sep 23, 2024
twiss
approved these changes
Sep 23, 2024
Member
twiss
left a comment
twiss
left a comment
There was a problem hiding this comment.
Thanks @javifernandez, and thanks all for the reviews!
This was referenced Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply some refactoring to the code already used for OPK keys.