Fix focus related failures due to URL bar being focused on launch#56270
Merged
annevk merged 4 commits intoweb-platform-tests:masterfrom Dec 16, 2025
Merged
Fix focus related failures due to URL bar being focused on launch#56270annevk merged 4 commits intoweb-platform-tests:masterfrom
annevk merged 4 commits intoweb-platform-tests:masterfrom
Conversation
Chromium-based browsers automatically focus the URL bar on launch which can prevent focus events from firing. Fix this by ensuring the page has focus first and in some cases simply change the expectation to use document.activeElement instead. Signed-off-by: Orko Garai <orko@igalia.com>
Signed-off-by: Orko Garai <orko@igalia.com>
Contributor
Author
|
FWIW I'm also looking at making a change via command line flag to not autofocus the URL bar when starting chrome from WPT tests:
If that solution is preferred over this, I can cancel this change. |
annevk
reviewed
Nov 27, 2025
html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable.html
Outdated
Show resolved
Hide resolved
...semantics/interactive-elements/the-dialog-element/remove-dialog-should-unblock-document.html
Outdated
Show resolved
Hide resolved
annevk
approved these changes
Nov 30, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Looks more reasonable now. I'm assuming this doesn't regress the tests in any browser. I hope you checked for that.
Contributor
Author
Yes, tested firefox, chromium and webkit, if that's okay. |
Contributor
Author
|
Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium-based browsers automatically focus the URL bar on launch which can prevent focus events from firing. Fix this by ensuring the page has focus first.