[BUGFIX] Ensure returned value to CKeditor is not entity encoded#12
Merged
[BUGFIX] Ensure returned value to CKeditor is not entity encoded#12
Conversation
While debugging, a `console.log` was forgotten to remove. As this could lead to issues in some browsers, remove the code.
The `HtmlParser` used the DOM Document methods saving the html for the return to the system. THis is fine, but with `DOMDocument::saveHTML()` all possible characters were converted to their respective html entities. While working inside TYPO3, the main character encoding is `UTF-8` in most cases and the result should return the content `as-is` and not with entities encoded. With switching the parser to return the rendered XML, this issue doesn't appear, as `DOMDocument::saveXML()` doesn't convert to HTML entities.
calien666
force-pushed
the
task/improvements
branch
from
4da25be to
c3ade10
Compare
sbuerk
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HtmlParserused the DOM Document methods saving the html for thereturn to the system. This is fine, but with
DOMDocument::saveHTML()all possible characters were converted to their respective html
entities. While working inside TYPO3, the main character encoding is
UTF-8in most cases and the result should return the contentas-isand not with entities encoded.
With switching the parser to return the rendered XML, this issue doesn't
appear, as
DOMDocument::saveXML()doesn't convert to HTML entities.