This repository was archived by the owner on Mar 5, 2025. It is now read-only.
eth.getBlock with hydrated = true returning empty transaction objects#5556
Merged
jdevcs merged 6 commits intoNov 1, 2022
Merged
Conversation
8b65b2d to
729b1ac
Compare
jdevcs
suggested changes
Oct 25, 2022
jdevcs
left a comment
Contributor
There was a problem hiding this comment.
In existing integration test , there should be additional check of transactions list present in case of hydrated true. or we can add a new test for querying a block with txs on some existing testnet.
luu-alex
approved these changes
Oct 29, 2022
avkos
approved these changes
Oct 31, 2022
jdevcs
approved these changes
Nov 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solution for #5470
eth.getBlockwas returning an empty object forblock.transactions.The error was in
web3.js/packages/web3-utils/src/formatter.ts
Line 158 in bfce27f
findSchemaByDataPath, which doesn't handle theoneOftype ( and couldn't since no info is passed in order to choose the right one.)My proposed solution is to save the options of
oneOfand pass them tofindSchemaByDataPath.This was my testcase