Add an error message when assigning Translatables with mismatching $locale#79
Open
MalteWunsch wants to merge 3 commits intomasterfrom
Open
Add an error message when assigning Translatables with mismatching $locale#79MalteWunsch wants to merge 3 commits intomasterfrom
MalteWunsch wants to merge 3 commits intomasterfrom
Conversation
…ocale This is more helpful than the error thrown otherwise: ``` Error: Typed property Webfactory\Bundle\PolyglotBundle\Doctrine\PersistentTranslatable::$primaryValue must not be accessed before initialization ```
Member
Author
|
The error message got a little bit verbose in the end, but in a way that would have helped me in different situations. I am however open for other messages as well. I wondered how this change should be categorized in terms of semantic versioning. I think it only improves the message for an unavoidable error, so it does not break any new things => Bugfix seems to be appropriate for me. Agreed? |
Member
Author
|
Seems this change could make #50 more difficult (but I don't see this as a blocking issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more helpful than the error thrown otherwise: