feat: add project ID and resource prefix to webiny info output#4937
feat: add project ID and resource prefix to webiny info output#4937
Conversation
Co-authored-by: adrians5j <5121148+adrians5j@users.noreply.github.com>
adrians5j
left a comment
There was a problem hiding this comment.
✖ @webiny/cli-core
src/features/DeployCommand/DeployCommand.ts(147,65): error TS2345: Argument of type '{ getProjectSdkService: IGetProjectSdkService; uiService: IUiService; }' is not assignable to parameter of type 'IPrintInfoForEnvDi'.
Type '{ getProjectSdkService: IGetProjectSdkService; uiService: IUiService; }' is missing the following properties from type 'IPrintInfoForEnvDi': getProjectIdService, getPulumiResourceNamePrefix @copilot
Co-authored-by: adrians5j <5121148+adrians5j@users.noreply.github.com>
Fixed in commit 08a3490. Updated DeployCommand to inject and pass GetProjectIdService and GetPulumiResourceNamePrefix to PrintInfoForEnv. |
|
|
||
| const { env, variant } = params; | ||
|
|
||
| const projectId = await getProjectIdService.execute(); |
There was a problem hiding this comment.
do not use abstractions here.... projectSDK itself has these methods exposed I believe
getPulumiResourceNamePrefix
getProjectId
There was a problem hiding this comment.
Refactored in commit 7d5d9a9. Now using projectSdk.getProjectId() and projectSdk.getPulumiResourceNamePrefix() directly instead of injecting service abstractions.
Co-authored-by: adrians5j <5121148+adrians5j@users.noreply.github.com>
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.