Skip to content

validate arguments to resolve and use callback for errors#261

Merged
sokra merged 1 commit into
masterfrom
bugfix/parse-crash
Oct 23, 2020
Merged

validate arguments to resolve and use callback for errors#261
sokra merged 1 commit into
masterfrom
bugfix/parse-crash

Conversation

@sokra
Copy link
Copy Markdown
Member

@sokra sokra commented Oct 23, 2020

No description provided.

@webpack-bot
Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2020

Codecov Report

Merging #261 into master will decrease coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   94.46%   94.43%   -0.04%     
==========================================
  Files          39       39              
  Lines        1536     1544       +8     
==========================================
+ Hits         1451     1458       +7     
- Misses         85       86       +1     
Impacted Files Coverage Δ
lib/Resolver.js 86.72% <87.50%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f51a8c...a2d2b4c. Read the comment docs.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants