Skip to content

refactor(siwe): ox#3151

Closed
tmm wants to merge 1 commit intomainfrom
tmm/refactor-siwe
Closed

refactor(siwe): ox#3151
tmm wants to merge 1 commit intomainfrom
tmm/refactor-siwe

Conversation

@tmm
Copy link
Copy Markdown
Member

@tmm tmm commented Dec 21, 2024

Drop bunch of code by using ox/Siwe internally

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Dec 21, 2024 0:44am

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: 5a2cf8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tmm tmm changed the title tmm/refactor siwe refactor(siwe): ox Dec 21, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (6ec6ad3) to head (5a2cf8c).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3151    +/-   ##
========================================
  Coverage   99.64%   99.65%            
========================================
  Files         891      888     -3     
  Lines       71727    71403   -324     
  Branches     3137     3077    -60     
========================================
- Hits        71471    71154   -317     
+ Misses        239      232     -7     
  Partials       17       17            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 64.6 KB (+2.79% 🔺) 1.3 s (+2.79% 🔺) 3.4 s (+66.85% 🔺) 4.7 s
const viem = require('viem') (cjs) 77.26 KB (+5.8% 🔺) 1.6 s (+5.8% 🔺) 2.4 s (-61.16% 🔽) 4 s
import { createClient, http } from 'viem' 6.33 KB (0%) 127 ms (0%) 441 ms (-6.34% 🔽) 568 ms
import * from 'viem/account-abstraction' 45.72 KB (0%) 915 ms (0%) 3.4 s (+5.33% 🔺) 4.3 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 35.64 KB (0%) 713 ms (0%) 2.7 s (+93.48% 🔺) 3.5 s
import * from 'viem/accounts' 82.52 KB (0%) 1.7 s (0%) 1.8 s (+14.59% 🔺) 3.4 s
import { privateKeyToAccount } from 'viem/accounts' 21.07 KB (0%) 422 ms (0%) 905 ms (-8.34% 🔽) 1.4 s
import { mnemonicToAccount } from 'viem/accounts' 27.37 KB (0%) 548 ms (0%) 769 ms (-68.87% 🔽) 1.4 s
import * from 'viem/actions' 47.98 KB (0%) 960 ms (0%) 3.3 s (+56.85% 🔺) 4.3 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 32 ms (+116.84% 🔺) 42 ms
import * from 'viem/chains' 41.11 KB (0%) 823 ms (0%) 3.5 s (+11.64% 🔺) 4.3 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 46 ms (+293.64% 🔺) 56 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 24 ms (+18.15% 🔺) 46 ms
import * from 'viem/ens' 47.29 KB (0%) 946 ms (0%) 2.2 s (+9.9% 🔺) 3.1 s
import { getEnsAvatar } from 'viem/ens' 22.42 KB (0%) 449 ms (0%) 1.7 s (-34.51% 🔽) 2.1 s
import * from 'viem/siwe' 33.32 KB (+6% 🔺) 667 ms (+6% 🔺) 2.7 s (+20.63% 🔺) 3.4 s
import { verifySiweMessage } from 'viem/siwe' 32.21 KB (+6.09% 🔺) 645 ms (+6.09% 🔺) 2.2 s (-7.96% 🔽) 2.9 s

@tmm tmm marked this pull request as ready for review December 21, 2024 07:04
@tmm
Copy link
Copy Markdown
Member Author

tmm commented Jan 9, 2025

Closing for now. Viem v3 on the horizon and will take care of all this.

@tmm tmm closed this Jan 9, 2025
@jxom jxom deleted the tmm/refactor-siwe branch January 9, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant