"Add to Team" fixes and task-status-list-retrieve changed to POST fix#144
Merged
DaleMcGrew merged 9 commits intowevote:developfrom Mar 16, 2026
Merged
Conversation
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data));
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Fixes https://wevoteusa.atlassian.net/browse/WV-2668 Fixes https://wevoteusa.atlassian.net/browse/WV-2553 REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124 Do not add a Person to addToTeamListTemp in AddPersonDrawerMainContent if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade -- this stops you from adding a Person to a team, who will not be displayable on the team list.. Person save was sending a URL like this: https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e Maybe this is due to some library upgrade (this is really worrisome for other API calls possibly "breaking" in the same way!) Fixed it with personSave(makeRequestParamsDictionary(plainParams, data)); Monday Mar 16: "{\"0\":\"p\",\"1\":\"e\",\"2\":\"r\",\"3\":\"s\",\"4\":\"o\",\"5\":\"n\",\"6\":\"I\",\"7\":\"d\",\"8\":\"=\",\"9\":\"5\",\"10\":\"1\",\"11\":\"3\",\"12\":\"&\",\"13\":\"t\",\"14\":\"a\",\"15\":\"s\",\"16\":\"k\",\"17\":\"D\",\"18\":\"e\",\"19\":\"f\",\"20\":\"i\",\"21\":\"n\",\"22\":\"i\",\"23\":\"t\",\"24\":\"i\",\"25\":\"o\",\"26\":\"n\",\"27\":\"I\",\"28\":\"d\",\"29\":\"=\",\"30\":\"2\",\"31\":\"8\",\"32\":\"&\",\"33\":\"d\",\"34\":\"o\",\"35\":\"n\",\"36\":\"e\",\"37\":\"B\",\"38\":\"y\",\"39\":\"P\",\"40\":\"e\",\"41\":\"r\",\"42\":\"s\",\"43\":\"o\",\"44\":\"n\",\"45\":\"I\",\"46\":\"d\",\"47\":\"T\",\"48\":\"o\",\"49\":\"B\",\"50\":\"e\",\"51\":\"S\",\"52\":\"a\",\"53\":\"v\",\"54\":\"e\",\"55\":\"d\",\"56\":\"=\",\"57\":\"9\",\"58\":\"4\",\"59\":\"&\",\"60\":\"d\",\"61\":\"o\",\"62\":\"n\",\"63\":\"e\",\"64\":\"B\",\"65\":\"y\",\"66\":\"P\",\"67\":\"e\",\"68\":\"r\",\"69\":\"s\",\"70\":\"o\",\"71\":\"n\",\"72\":\"I\",\"73\":\"d\",\"74\":\"C\",\"75\":\"h\",\"76\":\"a\",\"77\":\"n\",\"78\":\"g\",\"79\":\"e\",\"80\":\"d\",\"81\":\"=\",\"82\":\"t\",\"83\":\"r\",\"84\":\"u\",\"85\":\"e\",\"86\":\"&\",\"87\":\"s\",\"88\":\"t\",\"89\":\"a\",\"90\":\"t\",\"91\":\"u\",\"92\":\"s\",\"93\":\"D\",\"94\":\"o\",\"95\":\"n\",\"96\":\"e\",\"97\":\"T\",\"98\":\"o\",\"99\":\"B\",\"100\":\"e\",\"101\":\"S\",\"102\":\"a\",\"103\":\"v\",\"104\":\"e\",\"105\":\"d\",\"106\":\"=\",\"107\":\"t\",\"108\":\"r\",\"109\":\"u\",\"110\":\"e\",\"111\":\"&\",\"112\":\"s\",\"113\":\"t\",\"114\":\"a\",\"115\":\"t\",\"116\":\"u\",\"117\":\"s\",\"118\":\"D\",\"119\":\"o\",\"120\":\"n\",\"121\":\"e\",\"122\":\"C\",\"123\":\"h\",\"124\":\"a\",\"125\":\"n\",\"126\":\"g\",\"127\":\"e\",\"128\":\"d\",\"129\":\"=\",\"130\":\"t\",\"131\":\"r\",\"132\":\"u\",\"133\":\"e\",\"queryKey\":\"task-save\",\"isGet\":true,\"forceMaster\":false}"
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://wevoteusa.atlassian.net/browse/WV-2553
Fixes https://wevoteusa.atlassian.net/browse/WV-2669
Fixes https://wevoteusa.atlassian.net/browse/WV-2668
REQUIRES SERVER SIDE CHANGE wevote/weconnect-server#124
PROBLEM 1
We were allowing person on the addToTeamListTemp in AddPersonDrawerMainContent who if added to the team, were not allowed to be displayed on the Team tab. So now we won't display candidate team members if they are not statusActive or are statusResigned or are statusOfferWillNotBeMade.
PROBLEM 2:
Person save was sending a URL like this:
https://wevotedeveloper.com:4500/apis/v1/person-save/?0=p&1=e&2=r&3=s&4=o&5=n&6=I&7=d&8=%3D&9=2&10=7&11=4&12=%26&13=f&14=i&15=r&16=s&17=t&18=N&19=a&20=m&21=e&22=T&23=o&24=B&25=e&26=S&27=a&28=v&29=e&30=d&31=%3D&32=M&33=e&34=g&35=a&36=n&37=%25&38=2&39=0&40=D&41=E&42=L&43=E&44=T&45=E&46=%25&47=2&48=0&49=2&50=%26&51=f&52=i&53=r&54=s&55=t&56=N&57=a&58=m&59=e&60=C&61=h&62=a&63=n&64=g&65=e&66=d&67=%3D&68=t&69=r&70=u&71=e
You can easily see these in the log by setting LOG_HTTP_REQUESTS to true in config.js
Possibly as a result of a library update breaking change, our code to handle URLs with search components is no longer are accepting concatenated string parameters (as a string), they now require dictionaries of parameters.
Fixed it with
personSave(makeRequestParamsDictionary(plainParams, data));
Also made the same fix for the following API queries that save data (and are HTTP GET requests that send the parameters on the url):
questionaireSave
personSave
questionSave
taskDefinitionSave
taskGroupSave
taskGroupTeamLinkSave
saveTask
There may be more of these, but I don't know all the intricacies of the app to find all of the instances.
I didn't want to change code of this type, that I could not test.
PROBLEM 3
After lots of testing, I found that we were unable to save the text[] in the Teams departments columns in the form of '{"Engineering"}'. For whatever reason it was being added by our code (and via PGAdmin4) as '{Engineering}' which worked for our app, but was invalid SQL and failed FastLoad. So I changed the one-word department names to two-word names with a space and now they all save correctly, and once this change gets to the production server, I expect that fast load will work again.