Skip to content

Comments

Fix missing clusters split while jumping back#59

Open
HaoQChen wants to merge 2 commits intowg-perception:indigo-develfrom
HaoQChen:indigo-devel
Open

Fix missing clusters split while jumping back#59
HaoQChen wants to merge 2 commits intowg-perception:indigo-develfrom
HaoQChen:indigo-devel

Conversation

@HaoQChen
Copy link

@HaoQChen HaoQChen commented May 7, 2018

ScanProcessor::splitConnected(float thresh) currently only consider the situation that range increase suddenly but ignore sudden decrease. When sudden decrease occurs, it will jump to "else" to "++s_rest". If range is far enough, "expand" will be 1 or 2, nothing happen. But if range is very close, it may miss a jumping back, which will led to incorrect clusters split.

I think we just need to add a "std::abs(float)" to the "if"

@HaoQChen
Copy link
Author

HaoQChen commented May 8, 2018

leg_detector->void pairLegs(). At the second loop that "Attempt to pair up legs with no id", did you forget to change "closest_dist" to "d" when a pair of better legs appear. If we don't do that, it will only remember the first pair and every thing else we do will be forgot. And I think we just need to loop "leg2" from "leg1 + 1", cause the distance is scalar not vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant