Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 34.26% 34.26%
=======================================
Files 58 58
Lines 2072 2072
Branches 99 99
=======================================
Hits 710 710
Misses 1360 1360
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
QMasterMoo
left a comment
There was a problem hiding this comment.
So far, so good.
However, this is missing some features required for development
- the
tiltutility should be installed - a kubernetes environment for tilt should be mad available
- tilt requires kubernetes to run
- use kind or ctlptl or the docker built in kubernetes
- just make tilt work in the dev container with it
- temporal cli should be installed
There was a problem hiding this comment.
should this be built using the existing docker file? Is there a way to keep them in sync? I fear this would not be updated with time.
There was a problem hiding this comment.
Good point! Fixed in commit f680458. The devcontainer now uses the existing Dockerfile as its base (target: "base"), which automatically keeps UV versions and other dependencies in sync. This eliminates the maintenance issue of having duplicate version specifications.
There was a problem hiding this comment.
Likewise, this uv version is out of date and will be updated by a human developer at some point. The human developer is likely to forget this file. No amount of documentation will fix this. You must share the versions and consolidate setup scripts
There was a problem hiding this comment.
Exactly! Fixed in commit f680458. The setup script no longer installs UV separately since it now uses the project's Dockerfile as the base image, which already includes UV at the correct version. This consolidates the setup and eliminates version drift between files.
| "extensions": [ | ||
| "ms-python.python", | ||
| "ms-python.pylint", | ||
| "ms-python.black-formatter", | ||
| "ms-toolsai.jupyter", | ||
| "charliermarsh.ruff" | ||
| ], |
There was a problem hiding this comment.
Is this common? I feel weird specifying extensions here, but if it's normal I'm OK with it.
although, the black formatter should not be installed with ruff. Please keep ruff and remove black
There was a problem hiding this comment.
Yes, specifying extensions in devcontainer.json is common practice - it ensures consistent tooling across all developers. Removed the black formatter extension in commit f680458 and updated the formatting provider to use ruff instead, since ruff handles both linting and formatting.
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Added all the requested development tools in commit f680458:
The dev container now provides a complete local development environment with all necessary tools for working with the project's Kubernetes and Temporal infrastructure. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR adds a complete development container setup for the Friendly Computing Machine project, providing a consistent development environment across different machines and platforms.
What's Added
Core Dev Container Configuration
.devcontainer/devcontainer.json- Main configuration using Python 3.11 base image with Docker-in-Docker support.devcontainer/setup.sh- Automated setup script that handles all project-specific requirements.devcontainer/README.md- Comprehensive documentation for dev container usageKey Features
Environment Setup:
.python-versionfile)bin/generate_client.shVS Code Integration:
Automated Setup:
The setup script automatically:
uv syncto install all project dependenciesUsage
After setup, developers can immediately:
uv run pytestuv run fcm bot runuv run workflow runBenefits
Fixes #50.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.shcurl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.