[Explore Feed] Reactive load when tab and language changes#6628
Open
Williamrai wants to merge 2 commits into
Open
[Explore Feed] Reactive load when tab and language changes#6628Williamrai wants to merge 2 commits into
Williamrai wants to merge 2 commits into
Conversation
Williamrai
changed the title
Williamrai
commented
May 22, 2026
| @@ -156,7 +156,6 @@ class HomeFragment : Fragment() { | |||
| private val customizeInterestsLauncher = registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { | |||
| if (it.resultCode == RESULT_INTERESTS_UPDATED) { | |||
| Prefs.homeForYouModulesToday = "" | |||
Collaborator
Author
There was a problem hiding this comment.
This would still be manual call because right now we are not observing interest change flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why is this needed?
Current code has
_selectedTaband_wikiSIteas state but we load them manually. Whenever either changed, some caller had to remember to also call the right load/refresh function. This logic is spread across:So this PR makes loading a reaction to state not manual call.
Note:
HomeFragment.customizeInterestsLauncherstill need an explicit call since interest changed isn't observed as flow.