Skip to content

test: Support running unit tests on wasi#1759

Merged
davidlattimore merged 3 commits intowild-linker:mainfrom
bjorn3:wasi_tests
Apr 1, 2026
Merged

test: Support running unit tests on wasi#1759
davidlattimore merged 3 commits intowild-linker:mainfrom
bjorn3:wasi_tests

Conversation

@bjorn3
Copy link
Copy Markdown
Contributor

@bjorn3 bjorn3 commented Mar 24, 2026

I was able to get integration_tests.rs to compile with a bunch of patches, but it doesn't work as it needs to spawn a bunch of external processes. It is probably a better idea to compile integration_tests.rs for native and then instead have integration_tests.rs run the wild processes it starts in Wasmtime or another wasm engine.

@mati865
Copy link
Copy Markdown
Member

mati865 commented Mar 24, 2026

Oh, my bad I didn't check that previously. We are generating changelogs from PR titles using these filters:

wild/cliff.toml

Lines 61 to 80 in f0a5789

{ message = "^feat", group = "<!-- 00 -->🚀 Features" },
{ message = "^perf", group = "<!-- 01 -->⚡ Performance" },
# For now, we put stuff to ignore into its own group, which makes it easier to see what we're
# ignoring.
{ message = "^chore|cargo update", group = "<!-- 50 -->Ignored" },
{ message = "^fix", group = "<!-- 02 -->🪲 Bug Fixes" },
{ message = "^build", group = "<! -- 03 -->🏗️ Builds"},
{ message = "^doc", group = "<!-- 04 -->📚 Documentation" },
{ message = "^port", group = "<!-- 05 -->🕹️ Porting" },
{ message = "^style", group = "<!-- 06 -->🎨 Styling" },
{ message = "^packaging", group = "<!-- 07 -->📦 Packaging" },
{ message = "^tools", group = "<!-- 08 -->🛠️ Dev tooling" },
{ message = "^linker-diff", group = "<!-- 09 -->⚖️ Linker Diff" },
{ message = "^test|^ci", group = "<!-- 10 -->🧪 Testing" },
{ message = "^refactor", group = "<!-- 11 -->🔨 Refactor" },
{ body = ".*security", group = "<!-- 12 -->🛡️ Security" },
{ message = "^revert", group = "<!-- 13 -->◀️ Revert" },
{ message = "^*\\(deps", group = "<!-- 50 -->Ignored" },
{ message = ".*", group = "<!-- 11 -->💼 Other" },
]
also mentioned here https://github.com/wild-linker/wild/blob/f0a57890c196027339d2c32c13c7d38a3469f427/CONTRIBUTING.md#commit-messages

Mind updating the title?
Also, we squash PRs (mentioned in other CONTRIBUTING.md section). So, you might want to split the commits into separate PRs if you want them to end up as distinct ones.

@davidlattimore
Copy link
Copy Markdown
Member

Changes look good to me. I'm happy to squash them as-is if that's what you want. Or if you'd prefer the commit "Simplify integration tests Program::run" to be separate, it could be a separate PR. Our reason for squashing BTW, is that we like to have PR numbers in all commit messages, since it makes the release notes nicer.

Do you think we should update ci.yml so that the tests get run in CI?

@bjorn3 bjorn3 changed the title Support running unit tests on wasi test: Support running unit tests on wasi Apr 1, 2026
bjorn3 added 2 commits April 1, 2026 12:28
wait-timeout doesn't build for wasi. It is only used by integration
tests, but still blocks the build of unit tests.
@davidlattimore davidlattimore merged commit 579c493 into wild-linker:main Apr 1, 2026
24 checks passed
@bjorn3 bjorn3 deleted the wasi_tests branch April 1, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants