test: Support running unit tests on wasi#1759
Merged
davidlattimore merged 3 commits intowild-linker:mainfrom Apr 1, 2026
Merged
test: Support running unit tests on wasi#1759davidlattimore merged 3 commits intowild-linker:mainfrom
davidlattimore merged 3 commits intowild-linker:mainfrom
Conversation
Member
|
Oh, my bad I didn't check that previously. We are generating changelogs from PR titles using these filters: Lines 61 to 80 in f0a5789 Mind updating the title? |
Member
|
Changes look good to me. I'm happy to squash them as-is if that's what you want. Or if you'd prefer the commit "Simplify integration tests Program::run" to be separate, it could be a separate PR. Our reason for squashing BTW, is that we like to have PR numbers in all commit messages, since it makes the release notes nicer. Do you think we should update ci.yml so that the tests get run in CI? |
wait-timeout doesn't build for wasi. It is only used by integration tests, but still blocks the build of unit tests.
davidlattimore
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to get integration_tests.rs to compile with a bunch of patches, but it doesn't work as it needs to spawn a bunch of external processes. It is probably a better idea to compile integration_tests.rs for native and then instead have integration_tests.rs run the wild processes it starts in Wasmtime or another wasm engine.