[#156] splitting azure into non-wildfly and wildfly module#168
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| byte[] digest = sha256.digest(); | ||
| return BaseEncoding.base16().encode(digest); | ||
| protected static String sum(String str) throws NoSuchAlgorithmException, UnsupportedEncodingException { | ||
| MessageDigest digest = MessageDigest.getInstance("SHA-3"); |
Check failure
Code scanning / CodeQL
Use of a potentially broken or risky cryptographic algorithm
| static OnlineManagementClient staticMngmtClient; | ||
|
|
||
| @AzureVirtualMachine(name = AzureTestConstants.instanceName, group = SunstoneResourceAzSuiteTests.group, mode = OperatingMode.STANDALONE, standalone = @StandaloneMode(user = AzureTestConstants.mngmtUser, password = AzureTestConstants.mngmtPassword, port = AzureTestConstants.mngmtPort)) | ||
| @AzureVirtualMachine(name = AzureTestConstants.instanceName, group = AzStandaloneManagementClientTests.group) |
There was a problem hiding this comment.
One can even say, having it separated like this is even cleaner/nicer. Btw. haven't we discussed this option in past?
But we can see (in this MR) it comes with bigger complexity/work. Now question is if it is worth in long term.
There was a problem hiding this comment.
We might have:)
Yeah, te project is more complex. Modules kinda extending other modules and depending on them, not really something that is widely used. However, the vision is to enable cross team collaboration. How much does it worth it is yet to be determined.
| import java.util.Optional; | ||
|
|
||
|
|
||
| public class AzureArchiveDeployerProvider implements SunstoneArchiveDeployerProvider { |
There was a problem hiding this comment.
Just idea. Isn't product agnostic way of deployment copying war/jar "somewhere" on azure. I saw sunstone is already dealing with ftp in some cases. Can't that be used?
There was a problem hiding this comment.
It depends on the resource. On VMs, there is no universal way. On App Services, partially yes, you can specify a gith repository. On the other hand appservice.deploy() (from Azure SDK) supports only WAR archive type for EAP stack and not JAR, nor EAR.
rsvoboda
left a comment
rsvoboda
left a comment
There was a problem hiding this comment.
I have no objections to the changes, some polish needs to be done - comments by Martin.
I welcome the split as it helps to keep the abstraction on reasonable level and prevents to close bonding. And it keeps the doors open for addition of new runtimes.
|
Merging... |
4 participants
For #156
@mchoma @rsvoboda
Key changes:
azuremodule split intoazureandazure-wildfly. The latter one is extending the first one bringing additional support for injectingOnlineManagementClientand deploying Archive (this operation is product specific).coremodule split intocoreandcore-wildfly. The later one brings WildFly specific annotations and dependencies (creaper , ...)Examples:
WildFlyannotation. If not present, default one will be used. This principle is used also for injectingOnlineManagementClient.