Skip to content

Comments

Enhancement: Adds return types on ClassMetadata serialization methods#340

Merged
goetas merged 2 commits intowilldurand:masterfrom
mvhirsch:feature/classmetadata
Jul 8, 2025
Merged

Enhancement: Adds return types on ClassMetadata serialization methods#340
goetas merged 2 commits intowilldurand:masterfrom
mvhirsch:feature/classmetadata

Conversation

@mvhirsch
Copy link
Contributor

Fixes:

Method "Metadata\ClassMetadata::serialize()" might add "string" as a native return type declaration in the future. Do the same in child class "Hateoas\Configuration\Metadata\ClassMetadata" now to avoid errors or add an explicit @return annotation to suppress this message

Method "Metadata\ClassMetadata::unserialize()" might add "void" as a native return type declaration in the future. Do the same in child class "Hateoas\Configuration\Metadata\ClassMetadata" now to avoid errors or add an explicit @return annotation to suppress this message.

@goetas
Copy link
Collaborator

goetas commented Jun 13, 2025

can you please check phpcs failures?

@mvhirsch
Copy link
Contributor Author

can you please check phpcs failures?

Fixed in #341

@mvhirsch mvhirsch force-pushed the feature/classmetadata branch from a967afb to 2df20fd Compare July 8, 2025 08:08
@mvhirsch
Copy link
Contributor Author

mvhirsch commented Jul 8, 2025

@goetas Rebased 👍

@goetas goetas merged commit 19e6597 into willdurand:master Jul 8, 2025
69 checks passed
@mvhirsch mvhirsch deleted the feature/classmetadata branch July 9, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants