Added a factory method that supports BASIC auth.#12
Open
carlossg wants to merge 1 commit intowillroden:masterfrom
Open
Added a factory method that supports BASIC auth.#12carlossg wants to merge 1 commit intowillroden:masterfrom
carlossg wants to merge 1 commit intowillroden:masterfrom
Conversation
My original requirement is to be able to send an HTTP basic authentication along with requests. I took the liberty to also add a version of a method that takes arbitrary RequestInterceptors to support other possible modes of authentication, and general control. I think it's worthwhile doing this now to avoid ending up with 20 different overloaded flavors of the getInstance() method, but I can imagine you might not want to expose Feign or perhaps go the other way and not have the getInstanceWithBasicAuth method.
Author
|
Related to #8 |
Member
|
I think I like this way of handling it, but I want to sleep on it before I merge. |
There was a problem hiding this comment.
requestInterceptors overwrites existing requestInterceptors, so the MarathonHeadersInterceptor gets removed in the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My original requirement is to be able to send an HTTP basic
authentication along with requests.
I took the liberty to also add a version of a method that takes
arbitrary RequestInterceptors to support other possible modes of
authentication, and general control. I think it's worthwhile doing this
now to avoid ending up with 20 different overloaded flavors of the
getInstance() method, but I can imagine you might not want to expose
Feign or perhaps go the other way and not have the
getInstanceWithBasicAuth method.