Add ability to force delete a group and add ability to add app depenedencies #21
Open
estu0002 wants to merge 3 commits intowillroden:masterfrom
Open
Add ability to force delete a group and add ability to add app depenedencies #21estu0002 wants to merge 3 commits intowillroden:masterfrom
estu0002 wants to merge 3 commits intowillroden:masterfrom
Conversation
seh
reviewed
Oct 14, 2016
| private Collection<Task> tasks; | ||
| private Integer tasksStaged; | ||
| private Integer tasksRunning; | ||
| private String id; |
There was a problem hiding this comment.
- Here and throughout, revert these whitespace changes.
They add noise to this change and make it harder to evaluate what's materially different.
Author
There was a problem hiding this comment.
@seh Sorry about that. I thought I took care of that with a reformat of the file, but it seems as if four spaces and tabs are used inconsistently in some files in your master branch. I cleaned them up as best I could so it should be clear what changed now.
There was a problem hiding this comment.
It's not my branch, but I understand what you mean. When editing these files—even with their maddening formatting—I've tried to adhere to the "When in Rome, do as the Romans do" maxim: try to match what's there, and change as little as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to be able to do these two things but was unable to with the current code, so I added them.