Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
token_bucketrate limiter allocated a per-keytokenBucketentry and never removed it, allowing an attacker to cause unbounded memory growth by using many unique keys.Description
NewRateLimiterfor thetoken_bucketstrategy that creates atime.Tickerand deletes bucket entries whoselasttimestamp is older than the configured window (duration).donechannel so limiter lifecycle andStop()behavior remain unchanged.TestTokenBucketEvictsIdleBucketsinapp/ratelimiter_test.gothat verifies idle token-bucket entries are evicted after the configured window.app/main.goandapp/ratelimiter_test.go.Testing
go test ./appand all tests passed successfully.TestTokenBucketEvictsIdleBucketswas executed as part of the test run and passed.Codex Task