Skip to content

Fix flaky transport mutation assertion in TestIntegrationPluginTransport#620

Merged
winhowes merged 1 commit intomainfrom
codex/find-and-fix-failing-unit-tests
Apr 13, 2026
Merged

Fix flaky transport mutation assertion in TestIntegrationPluginTransport#620
winhowes merged 1 commit intomainfrom
codex/find-and-fix-failing-unit-tests

Conversation

@winhowes
Copy link
Copy Markdown
Owner

Motivation

  • The test TestIntegrationPluginTransport assumed the base transport's IdleConnTimeout was 0, which can vary by environment and caused intermittent failures; the test should instead snapshot and assert the value is preserved.

Description

  • Capture baseTr.IdleConnTimeout before calling AddIntegration and assert baseTr.IdleConnTimeout remains equal to that snapshot after the call, updating app/integration_test.go accordingly.

Testing

  • Ran go test ./app -run TestIntegrationPluginTransport -count=1 which passed, and go test ./... which also passed.

Codex Task

@winhowes winhowes merged commit 042ed41 into main Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant