[codex] Add metrics for proxy-generated responses#624
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
authtranslator_auth_failures_total, and locally generated 4xx/5xx responses such as integration lookup failures, invalid destinations, rate-limit rejections, and missing proxy configuration were not exposed as a bounded Prometheus counter.Description
authtranslator_internal_responses_total{integration,code,reason}for proxy-generated non-upstream responses, using coarse bounded reason labels.proxyHandler, including integration not found, incoming auth failure, caller/integration rate limiting, denylist/allowlist rejections, invalid destination, outgoing auth failure, and no proxy configured.authtranslator_auth_failures_totalmetric so auth failures are represented consistently regardless of direction.docs/observability.md.Impact
reasonlabel stays low-cardinality by using fixed categories rather than raw error text.Testing
go test ./app/metrics -count=1go test ./app -run 'TestProxyHandler(RateLimiterUsesIP|RetryAfterOutLimit|NotFound|AuthFailure|BadGateway|WildcardMissingDestination|OutgoingAuthError)$' -count=1go test ./app -run 'TestProxyHandler(Denylist|NotFound|AuthFailure|BadGateway|WildcardMissingDestination|OutgoingAuthError)$|TestConstraintFailureReasonHeader|TestAllowlist|TestProxyHandlerRateLimiterUsesIP|TestProxyHandlerRetryAfterOutLimit' -count=1go test ./... -count=1currently fails in this environment due the pre-existing unrelatedTestRateLimiterRedisTLSAuthRequiresVerificationcertificate-key-size error inapp/redis_tls_auth_test.go.