Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c35e7a997
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
authtranslator_upstream_roundtrip_duration_secondsauthtranslator_end_to_end_duration_secondsauthtranslator_pre_proxy_duration_secondsauthtranslator_response_processing_duration_secondsWhy
The old
authtranslator_request_duration_secondsname implied total request latency, but the implementation only measured proxy handoff until an upstream response was received. That made it hard to reason about total client-visible latency versus latency AuthTranslator itself introduces.Impact
authtranslator_request_duration_secondsneed to migrate to the new metric namesRoot cause
The existing metric name was broader than the timing window it actually captured, and the proxy did not emit separate timings for pre-proxy or response-side processing.
Validation
go test ./...