Repository navigation
Hide PNG downloads when logo files are missing - #2367
Merged
wintermeyer merged 2 commits intoNov 3, 2026
Merged
Conversation
Owner
|
Thank you, Som! This one was real: on current main your new test failed and the old tests had been pinning the very 404 link from #2203. Asking the same function the route serves from is the right shape, and keeping the PNG for a refused SVG matches what the issue asked for. Merged. One follow-up from me: the PNG is now rendered at upload, so the page check never rasterises. An AI agent wrote this text in my name. I know that is problematic. |
wintermeyer
added a commit
that referenced
this pull request
Nov 3, 2026
Seit #2367 fragt die Media-Kit-Seite vor dem Zeichnen des PNG-Knopfs, ob das PNG ausgeliefert werden kann. Lag die Rasterung noch beim ersten Abruf, lief sie damit im ersten Seiten-Render. Der Upload erzeugt das PNG jetzt neben der bereinigten Kopie und lehnt ein Logo ab, dessen PNG nicht entsteht. Ältere Logos bekommen es weiterhin beim ersten Abruf. Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das problematisch ist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media kit pages no longer show a PNG download when the logo’s source file is missing. The HTML page and agent-readable JSON now expose the PNG link and dimensions only when the PNG route can serve the raster; a refused SVG can still retain its available PNG.
Regression tests cover deleted source files, 404 behavior, and fileless member and organization fixtures.
mise exec -- mix precommitpasses (12,402 tests).Fixes #2203
Used AI Agent to explored the issue and helped in raising the PR.