Skip to content

Hide PNG downloads when logo files are missing - #2367

Merged
wintermeyer merged 2 commits into
wintermeyer:mainfrom
SomSamantray:fix/2203-logo-png-link-no-files
Nov 3, 2026
Merged

wintermeyer merged 2 commits into
wintermeyer:mainfrom
SomSamantray:fix/2203-logo-png-link-no-files

Conversation

@SomSamantray

@SomSamantray SomSamantray commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Media kit pages no longer show a PNG download when the logo’s source file is missing. The HTML page and agent-readable JSON now expose the PNG link and dimensions only when the PNG route can serve the raster; a refused SVG can still retain its available PNG.

Regression tests cover deleted source files, 404 behavior, and fileless member and organization fixtures. mise exec -- mix precommit passes (12,402 tests).

Fixes #2203

Used AI Agent to explored the issue and helped in raising the PR.

@wintermeyer
wintermeyer merged commit e4cda52 into wintermeyer:main Nov 3, 2026
1 check passed
@wintermeyer

Copy link
Copy Markdown
Owner

Thank you, Som! This one was real: on current main your new test failed and the old tests had been pinning the very 404 link from #2203. Asking the same function the route serves from is the right shape, and keeping the PNG for a refused SVG matches what the issue asked for. Merged. One follow-up from me: the PNG is now rendered at upload, so the page check never rasterises.

An AI agent wrote this text in my name. I know that is problematic.

wintermeyer added a commit that referenced this pull request Nov 3, 2026
Seit #2367 fragt die Media-Kit-Seite vor dem Zeichnen des PNG-Knopfs, ob das PNG ausgeliefert werden kann. Lag die Rasterung noch beim ersten Abruf, lief sie damit im ersten Seiten-Render. Der Upload erzeugt das PNG jetzt neben der bereinigten Kopie und lehnt ein Logo ab, dessen PNG nicht entsteht. Ältere Logos bekommen es weiterhin beim ersten Abruf.

Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das problematisch ist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A logo with no files left still offers a PNG that 404s

2 participants