feat(nomad profiles): nomad profiles URL parsing and signature verification (WPB-23837)#4627
Open
marcoconti83 wants to merge 2 commits intomarco/nomad-profilesfrom
Open
feat(nomad profiles): nomad profiles URL parsing and signature verification (WPB-23837)#4627marcoconti83 wants to merge 2 commits intomarco/nomad-profilesfrom
marcoconti83 wants to merge 2 commits intomarco/nomad-profilesfrom
Conversation
marcoconti83
changed the title
marcoconti83
force-pushed
the
marco/nomad-profiles
branch
from
ea421d0 to
065d230
Compare
marcoconti83
force-pushed
the
feat/nomad-profile-build-flag
branch
2 times, most recently
from
5a4f6c4 to
f57f2fa
Compare
marcoconti83
force-pushed
the
marco/nomad-profiles
branch
from
065d230 to
a24639c
Compare
marcoconti83
force-pushed
the
feat/nomad-profile-build-flag
branch
from
f57f2fa to
c344664
Compare
marcoconti83
force-pushed
the
marco/nomad-profiles
branch
from
a24639c to
efca5fd
Compare
marcoconti83
force-pushed
the
feat/nomad-profile-build-flag
branch
from
c344664 to
b5c90e0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23837
What's new in this PR?
When starting an autologin intent, the app also parses an optional nomad profiles service host. The paramater is expected to be signed, i.e. there should be a signature passed to the intent.
The app will check that the parameter signatures one of the public keys hardcoded in the application. If it doesn't, it rejects it.
WARNING: This PR targets the
marco/nomad-profilesbranch because it should be merged AFTER that one.