Fix request storing when RequestLogExpirationDuration is set [bug] #1455
Merged
StefH merged 2 commits intowiremock:masterfrom May 11, 2026
Merged
Fix request storing when RequestLogExpirationDuration is set [bug] #1455StefH merged 2 commits intowiremock:masterfrom
StefH merged 2 commits intowiremock:masterfrom
Conversation
StefH
requested changes
May 7, 2026
Collaborator
|
@pbenko-xitaso |
Contributor
Author
|
Sorry, this PR was the last thing I did before falling sick last week. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #1454
ResponseMessageBuildernow properly sets the theResponse.DateTimeinstead of leaving it on itsdefault, which caused the immediate deletion of the Request downstream, when evaluatingRequests to purge.The
ResponseMessageBuilderisn't static anymore, to enable testing without propagating aDateTimeUtilitythroughout the codebase.Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java[ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org