Skip to content

Fix request storing when RequestLogExpirationDuration is set [bug] #1455

Merged
StefH merged 2 commits intowiremock:masterfrom
pbenko-xitaso:master
May 11, 2026
Merged

Fix request storing when RequestLogExpirationDuration is set [bug] #1455
StefH merged 2 commits intowiremock:masterfrom
pbenko-xitaso:master

Conversation

@pbenko-xitaso
Copy link
Copy Markdown
Contributor

References

Fixes #1454

ResponseMessageBuilder now properly sets the the Response.DateTime instead of leaving it on its default, which caused the immediate deletion of the Request downstream, when evaluating Requests to purge.

The ResponseMessageBuilder isn't static anymore, to enable testing without propagating a DateTimeUtility throughout the codebase.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • [ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Comment thread src/WireMock.Net.Minimal/ResponseMessageBuilder.cs Outdated
Comment thread src/WireMock.Net.Minimal/ResponseMessageBuilder.cs Outdated
@StefH StefH added the bug Something isn't working label May 7, 2026
@StefH
Copy link
Copy Markdown
Collaborator

StefH commented May 9, 2026

@pbenko-xitaso
Can you take a look at my comments?

@pbenko-xitaso
Copy link
Copy Markdown
Contributor Author

pbenko-xitaso commented May 11, 2026

Sorry, this PR was the last thing I did before falling sick last week.

Done.

@StefH StefH merged commit 67acdcf into wiremock:master May 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No requests stored in Standalone when RequestLogExpirationDuration is set

2 participants