passing string into is:inline style tag doesn't render said string as child text

[matthewp]

Astro Info

❯ npx astro info
Astro                    v4.9.2
Node                     v18.20.3
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

<style is:inline>{` h1 { color: ${color}; } `}></style>

Renders the code instead.

What's the expected result?

I was sort of expecting it to put the string child in there. Maybe there's a security consideration and set:html is better?

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-ncpwkk?file=src%2Fpages%2Findex.astro

Participation

• I am willing to submit a pull request for this issue.

[bluwy]

I think it's more that the compiler always expect CSS syntax in the <style> tag, so it sees the children as CSS and doesn't do JSX style interpolation. set:html seems like the better way for me.

[matthewp]

set:html does work, but I would expect that passing a string as a child to be escaped just like passing a string to any child tag. So I do think this is a case of the compiler having an issue specifically with style tags.

[matthewp]

(context is that we were talking about removing define:vars possibly in 5.0 and this seems like a fine alternative, hopefully an idea you would like @bluwy 😀)

[bluwy]

Sorry misclosed whle switching tab 😅 Typing my proper comment next

[bluwy]

If we have the compiler allowing {} within style tags, and also CSS syntax, wouldn't it be ambiguous when parsing? Unless we hardcode checking {` as the first character.

I'm open to re-thinking how interpolating vars work though. I think the ideal way is something like this?

<style is:inline>
  h1 {
    color: ${color};
  }
</style>

So you can use normal CSS syntax, and easily interpolate variables. I wrote an RFC for Svelte before (which didn't go through), but the conclusion was the same v-bind syntax as Vue as it's valid CSS syntax. We also get better syntax highlighting this way.

[matthewp]

@bluwy I do like that idea as a feature.

I don't think this would be ambiguous though. { is not a valid first character of a stylesheet is it? If so then I would agree with you.

[nanarino]

I think it's more that the compiler always expect CSS syntax in the <style> tag, so it sees the children as CSS and doesn't do JSX style interpolation. set:html seems like the better way for me.我認為更重要的是，編譯器總是期望 <style> 標籤中的 CSS 語法，因此它將子項視為 CSS，並且不會進行 JSX 樣式插值。 set:html 對我來說似乎是更好的方法。

I use script type='importmap' to import modules from CDN, but astro always lets me pnpm install .
Maybe set:html can help me

[ascorbic]

Closing while cleaning up because this isn't a bug, but a possible feature we might want to support. I don't think we're removing define:vars imminently, so it's not too pressing