fix(config): prevent vite from loading config#10360
Merged
bluwy merged 3 commits intowithastro:mainfrom Mar 8, 2024
Merged
Conversation
This fixes an issue where creating a vite server (to e.g. load a TypeScript astro config) would trigger vite to look up and load an unrelated vite config (potentially going up directories).
🦋 Changeset detectedLatest commit: 7109405 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
1 task
lilnasy
approved these changes
Mar 7, 2024
Contributor
lilnasy
left a comment
lilnasy
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks for taking this on.
Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>
Contributor
Author
|
@lilnasy thanks, PTAL! as far as I'm concerned you can merge |
bluwy
reviewed
Mar 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10262
Changes
This fixes an issue where creating a vite server (to e.g. load a TypeScript astro config) would trigger vite to look up and load an unrelated vite config (potentially going up directories).
Testing
This has not been tested because I'm not familiar with the astro testing setup...
Docs
This fixes an unexpected side effect of loading a TypeScript config. Since this is the expected behavior, it might not require documentation.