fix(tsconfigs): Add jsx: 'preserve' to the base template#10368
Merged
fix(tsconfigs): Add jsx: 'preserve' to the base template#10368
jsx: 'preserve' to the base template#10368Conversation
🦋 Changeset detectedLatest commit: e45cf28 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
florian-lefebvre
approved these changes
Mar 8, 2024
bluwy
approved these changes
Mar 8, 2024
ematipico
approved these changes
Mar 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Despite being supposed to only affect emitting, the
jsxsetting is required to import JSX and internally considered to be JSX files, or you get an error. This addsjsx: 'preserve', the safest setting to our base preset.This shouldn't affect anything, for two reasons:
astro add JSX_FRAMEWORKalready changes thetsconfig.jsonto something else for frameworks that need it (most of which are in fact, usingpreservealready)Fix withastro/language-tools#787
Testing
Tests should pass!
Docs
N/A