Overhaul errors for consistency and correctness#16593
Overhaul errors for consistency and correctness#16593yanthomasdev wants to merge 14 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: dd42e62 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will improve performance by 10.51%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | Build: hybrid site (static + server) |
10.6 s | 9.6 s | +10.51% |
Comparing errors-fix (dd42e62) with main (272185b)
| * - [Dynamic Routes](https://docs.astro.build/en/guides/routing/#dynamic-routes) | ||
| * - [`getStaticPaths()`](https://docs.astro.build/en/reference/routing-reference/#getstaticpaths) | ||
| * - [Server-side Rendering](https://docs.astro.build/en/guides/on-demand-rendering/) | ||
| * - [Server-side rendering](https://docs.astro.build/en/guides/on-demand-rendering/) |
There was a problem hiding this comment.
I wonder if we should take this opportunity to adjust the wording for consistency:
-Server-side rendering
+On-demand renderingBut this is used in several places so it might be easier to check the occurrence in an editor. That's said, this can also happen another time. Just a though while reviewing!
There was a problem hiding this comment.
True! I had that planned as a follow-up but forgot to mention in the PR description
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I'm not sure about the view transition test, but core-image.test.ts is flaky! I had to rerun the test a few times this morning to merge a docs-only PR. So, LGTM! Thank you!
delucis
left a comment
There was a problem hiding this comment.
Mostly looks great — @yanthomasdev! Just one comment.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Changes
This PR does an overhaul of all error messages to make them more consistent with each other, namely:
Testing
I am not sure if adding backticks in a few places could break rendering, we'll be sure once we get the automated PR on docs.
Docs
That's all it is.