fix(cloudflare): forward user optimizeDeps to SSR/prerender environments#16601
Open
maximslo wants to merge 5 commits intowithastro:mainfrom
Open
fix(cloudflare): forward user optimizeDeps to SSR/prerender environments#16601maximslo wants to merge 5 commits intowithastro:mainfrom
maximslo wants to merge 5 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 414a4a6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: integration
Remove duplicate AstroLogger block that was left over from the merge conflict; keep only the createLogger approach from main so biome lint no longer flags logger as unused.
maximslo
force-pushed
the
fix/cloudflare-user-optimizedeps-ssr
branch
from
c20bc8e to
414a4a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16491
Context: In Vite 6, top-level
vite.optimizeDepsonly applies to the client environment. The Cloudflare adapter owns SSR/prerender dep optimization via its configEnvironment hook, so user-configuredoptimizeDeps.excludeandoptimizeDeps.esbuildOptions.loaderwere silently ignored for server environments.Changes
config.vite.optimizeDepsinastro:config:setupand merge it into the adapter'sconfigEnvironmentreturn value for server environments.Added integration test: (test/custom-loader.test.ts) with a fixture containing a fake package that imports a.datafile, reproduces the esbuild "No loader is configured for .data files" error when the fix is absent.test/ssr-deps.test.tswith a dynamically-created fake-data-pkg that imports a .data file, reproduces the esbuild "No loader is configured for .data files" error when the fix is absent.Testing
NODE_OPTIONS="--experimental-strip-types --no-warnings"pnpm test in packages/integrations/cloudflare.ssr-deps.test.ts) CI is the source of truthDocs
Fix doesn't introduce any new config options or change any public API. No docs update needed.