fix(language-server): Don't depend on TypeScript being available

[Princesseuh]

Changes

Fixes #16612

Testing

Should pass! We unfortunately cannot test this in the monorepo because TypeScript is of course always available

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 5155dd1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[delucis]

What’s the actual call site that passes ts to these methods? Is it conditionally loading TypeScript based on availability?

We unfortunately cannot test this in the monorepo because TypeScript is of course always available

rm('node_modules/typescript', { recursive: true }) in the test suite you cowards!

Just kidding, I’m sure it’s fine.

[Princesseuh]

What’s the actual call site that passes ts to these methods? Is it conditionally loading TypeScript based on availability?

The language-server init point takes in a path to a tsdk, it does that because for instance, a project might not have TypeScript installed at all, but VS Code provides a global typescript outside of the project (hence the option to "Use workspace TypeScript" in the editor).

This also happens for users on Neovim and stuff, where their recommended workflow is to install TypeScript globally (literally npm -g typescript) and then in their Neovim config, point to the TypeScript they installed.

As such, you can never literally import from typescript, it always has to come from said init point