Fix: Check node version and find acceptable host accordingly#3599
Merged
natemoo-re merged 1 commit intowithastro:mainfrom Jun 15, 2022
arimgibson:fix/node18.1-host
Merged
Fix: Check node version and find acceptable host accordingly#3599natemoo-re merged 1 commit intowithastro:mainfrom arimgibson:fix/node18.1-host
natemoo-re merged 1 commit intowithastro:mainfrom
arimgibson:fix/node18.1-host
Conversation
🦋 Changeset detectedLatest commit: 27e70a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
natemoo-re
approved these changes
Jun 15, 2022
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Incredible, thank you so much for the PR!
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
unable to find network to exposewhen exposing to network with Node 18.1+ #3598devorpreviewon Node 18.1+Testing
As mentioned by @bholmesdev on #3547, this kind of change is hard to test because we have to manipulate the Node's
osresponse. However, for what it's worth, adding this fix locally fixed my issue (#3598)Docs
This change is not visible, meaning that documentation does not need to be updated.