Skip to content

[astro add] Support adapters and third party packages#3854

Merged
bholmesdev merged 13 commits into
mainfrom
feat/astro-add-adapter-third-party-support
Jul 8, 2022
Merged

[astro add] Support adapters and third party packages#3854
bholmesdev merged 13 commits into
mainfrom
feat/astro-add-adapter-third-party-support

Conversation

@bholmesdev
Copy link
Copy Markdown
Contributor

@bholmesdev bholmesdev commented Jul 7, 2022 •
edited
Loading

Changes

  • Detect adapters and integrations by package.json keywords!
    • astro-integration -> valid Astro integration
    • astro-adapter -> valid Astro adapter
  • Add package.json keywords across all official integrations and adapters
  • Correctly set the adapter in your astro config instead of blindly adding to integrations
  • Add warning + "continue?" prompt when installing third party integrations and adapters
  • Remove astro- package naming requirement for third party integrations

Testing

TODO

Docs

Document magic "keywords" in the integrations API and adapter API references for package authors ❤️
withastro/docs#946

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 7, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 6826650

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
astro Patch
@astrojs/cloudflare Patch
@astrojs/deno Patch
@astrojs/image Patch
@astrojs/lit Patch
@astrojs/mdx Patch
@astrojs/netlify Patch
@astrojs/node Patch
@astrojs/partytown Patch
@astrojs/preact Patch
@astrojs/prefetch Patch
@astrojs/react Patch
@astrojs/sitemap Patch
@astrojs/solid-js Patch
@astrojs/svelte Patch
@astrojs/tailwind Patch
@astrojs/turbolinks Patch
@astrojs/vercel Patch
@astrojs/vue Patch
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added pkg: astro Related to the core `astro` package (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Jul 7, 2022
bholmesdev
bholmesdev commented Jul 7, 2022
View reviewed changes
Comment thread packages/astro/src/core/add/index.ts
return integrationEntries;
} catch (e) {
if (e instanceof Error) {
spinner.fail(e.message);
Copy link
Copy Markdown
Contributor Author

@bholmesdev bholmesdev Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map errors to spinner.fail to avoid unnecessary stack traces!

@bholmesdev bholmesdev changed the title [astro add] Support adapters and third party integrations / adapters [astro add] Support adapters and third party packages Jul 7, 2022
natemoo-re
natemoo-re approved these changes Jul 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 Great update, thanks Ben! LGTM!

matthewp
matthewp approved these changes Jul 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@natemoo-re natemoo-re linked an issue Jul 8, 2022 that may be closed by this pull request
🐛 astro add vercel fails in a misleading way #3815
Closed
1 task
@bholmesdev bholmesdev merged commit b012ee5 into main Jul 8, 2022
@bholmesdev bholmesdev deleted the feat/astro-add-adapter-third-party-support branch July 8, 2022 20:55
@astrobot-houston astrobot-houston mentioned this pull request Jul 8, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@bholmesdev
[astro add] Support adapters and third party packages (withastro#3854)
57319c9 
* feat: support adapters and third part integrations by keywords

* refactor: add keywords to all official integrations

* docs: add adapter ex to astro add help

* nit: clarify astro add usage

* nit: highlight link

* fix: use process.exit(1) on error

* chore: changeset

* nit: bold integration name

* fix: log install instructions for adapters instead

* nit: change to logAdapterConfigInstructions

* Revert "fix: log install instructions for adapters instead"

This reverts commit 1a459f1.

* feat: add hardcoded adapter export map

* refactor: inline adapter config log
ematipico pushed a commit that referenced this pull request Feb 5, 2025
@bholmesdev
[astro add] Support adapters and third party packages (#3854)
5a87e44 
* feat: support adapters and third part integrations by keywords

* refactor: add keywords to all official integrations

* docs: add adapter ex to astro add help

* nit: clarify astro add usage

* nit: highlight link

* fix: use process.exit(1) on error

* chore: changeset

* nit: bold integration name

* fix: log install instructions for adapters instead

* nit: change to logAdapterConfigInstructions

* Revert "fix: log install instructions for adapters instead"

This reverts commit 1a459f1.

* feat: add hardcoded adapter export map

* refactor: inline adapter config log
ematipico pushed a commit that referenced this pull request Feb 5, 2025
@bholmesdev
[astro add] Support adapters and third party packages (#3854)
09542f3 
* feat: support adapters and third part integrations by keywords

* refactor: add keywords to all official integrations

* docs: add adapter ex to astro add help

* nit: clarify astro add usage

* nit: highlight link

* fix: use process.exit(1) on error

* chore: changeset

* nit: bold integration name

* fix: log install instructions for adapters instead

* nit: change to logAdapterConfigInstructions

* Revert "fix: log install instructions for adapters instead"

This reverts commit 1a459f1.

* feat: add hardcoded adapter export map

* refactor: inline adapter config log
ematipico pushed a commit that referenced this pull request Feb 6, 2025
@bholmesdev
[astro add] Support adapters and third party packages (#3854)
1e3f7f6 
* feat: support adapters and third part integrations by keywords

* refactor: add keywords to all official integrations

* docs: add adapter ex to astro add help

* nit: clarify astro add usage

* nit: highlight link

* fix: use process.exit(1) on error

* chore: changeset

* nit: bold integration name

* fix: log install instructions for adapters instead

* nit: change to logAdapterConfigInstructions

* Revert "fix: log install instructions for adapters instead"

This reverts commit 1a459f1.

* feat: add hardcoded adapter export map

* refactor: inline adapter config log
ematipico pushed a commit that referenced this pull request Feb 6, 2025
@bholmesdev
[astro add] Support adapters and third party packages (#3854)
5080786 
* feat: support adapters and third part integrations by keywords

* refactor: add keywords to all official integrations

* docs: add adapter ex to astro add help

* nit: clarify astro add usage

* nit: highlight link

* fix: use process.exit(1) on error

* chore: changeset

* nit: bold integration name

* fix: log install instructions for adapters instead

* nit: change to logAdapterConfigInstructions

* Revert "fix: log install instructions for adapters instead"

This reverts commit 1a459f1.

* feat: add hardcoded adapter export map

* refactor: inline adapter config log
ematipico pushed a commit that referenced this pull request Feb 7, 2025
@bholmesdev
[astro add] Support adapters and third party packages (#3854)
c3b62f3 
* feat: support adapters and third part integrations by keywords

* refactor: add keywords to all official integrations

* docs: add adapter ex to astro add help

* nit: clarify astro add usage

* nit: highlight link

* fix: use process.exit(1) on error

* chore: changeset

* nit: bold integration name

* fix: log install instructions for adapters instead

* nit: change to logAdapterConfigInstructions

* Revert "fix: log install instructions for adapters instead"

This reverts commit 1a459f1.

* feat: add hardcoded adapter export map

* refactor: inline adapter config log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewp matthewp matthewp approved these changes

+1 more reviewer

@natemoo-re natemoo-re natemoo-re approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 astro add vercel fails in a misleading way

3 participants

@bholmesdev @matthewp @natemoo-re