Skip to content

fix(create-astro): improve error messages when create-astro fails#5240

Merged
natemoo-re merged 1 commit into
mainfrom
fix/create-astro
Oct 28, 2022
Merged

fix(create-astro): improve error messages when create-astro fails#5240
natemoo-re merged 1 commit into
mainfrom
fix/create-astro

Conversation

@natemoo-re

Copy link
Copy Markdown
Member

Changes

  • There were two cases where create-astro would silently process.exit(1).
  • I think this might be making create-astro does not work #5227 worse than it seems.
  • This PR makes these exits log something so it's easier to debug.

Testing

Manually confirmed

Docs

N/A

@changeset-bot

changeset-bot Bot commented Oct 28, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 360faa5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: create-astro Related to the `create-astro` package (scope) label Oct 28, 2022
@natemoo-re natemoo-re mentioned this pull request Oct 28, 2022
1 task

@matthewp matthewp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@natemoo-re natemoo-re merged commit d9be7e3 into main Oct 28, 2022
@natemoo-re natemoo-re deleted the fix/create-astro branch October 28, 2022 19:05
@astrobot-houston astrobot-houston mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: create-astro Related to the `create-astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants