Skip to content

Unflag experimental features#5728

Merged
matthewp merged 7 commits into
mainfrom
feat/unflag
Jan 3, 2023
Merged

Unflag experimental features#5728
matthewp merged 7 commits into
mainfrom
feat/unflag

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re commented Jan 3, 2023

Changes

Unflags --experimental-error-overlay and --experimental-prerender

Testing

CI

Docs

N/A

@natemoo-re natemoo-re requested a review from a team as a code owner January 3, 2023 16:42
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 3, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d0db1e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Jan 3, 2023
@matthewp
Copy link
Copy Markdown
Contributor

matthewp commented Jan 3, 2023

The test failing here seems really bizarre...

@natemoo-re
Copy link
Copy Markdown
Member Author

natemoo-re commented Jan 3, 2023

The test failing here seems really bizarre...

This seems to have something to do with the prerender changes—I'll investigate.

delucis
delucis reviewed Jan 3, 2023
View reviewed changes
Comment thread .changeset/chilled-geese-worry.md Outdated
Comment thread packages/astro/src/@types/astro.ts
@natemoo-re
Copy link
Copy Markdown
Member Author

natemoo-re commented Jan 3, 2023

The test failing here seems really bizarre...

Figured this out. It was a test that we could customize vite.build.rollupOptions.output.chunkFileNames, but the package.json didn't include "type": "module" and the output files were plain .js (which would be treated as CJS in this case).

Since prerender splits each page out to a separate chunk instead of a single file, this broke. Made a specific note in the changelog for this situation.

@natemoo-re natemoo-re self-assigned this Jan 3, 2023
@matthewp matthewp merged commit 8fb2864 into main Jan 3, 2023
@matthewp matthewp deleted the feat/unflag branch January 3, 2023 19:05
@astrobot-houston astrobot-houston mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

@matthewp matthewp matthewp approved these changes

Assignees

@natemoo-re natemoo-re

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natemoo-re @matthewp @delucis