Fix Code.astro shiki css class replace logic#5829
Merged
Merged
Conversation
The replace uses a regex witch matches anything extra, and adds it back to the css class. Closes #5828
🦋 Changeset detectedLatest commit: 69b872c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
reviewed
Jan 11, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The replace uses a regex witch matches anything extra and adds it back to the css class.
Closes #5828
Testing
As mentioned in the linked issue #5828, the actual pinned shiki version v0.11 does work. The v0.12 causes the bug, as a new feature shikijs/shiki#376 adds an extra css class, making the actual logic to fail.
There's a test already in place
astro/packages/astro/test/astro-component-code.test.js
Lines 37 to 41 in 4b16e9e
Docs