fix: Don’t require getCollection() filter to be a type guard#5998
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ae244d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
andersk
force-pushed
the
collection-filter-overload
branch
from
6588286 to
387e00e
Compare
natemoo-re
approved these changes
Jan 26, 2023
andersk
force-pushed
the
collection-filter-overload
branch
from
d79c05b to
3448a0a
Compare
bholmesdev
reviewed
Jan 26, 2023
Contributor
bholmesdev
left a comment
bholmesdev
left a comment
There was a problem hiding this comment.
Eep! I remember testing this case but I'll trust if it broke on your end. Let me know if this nit also solves your issue.
bholmesdev
approved these changes
Jan 26, 2023
Commit dabce6b (withastro#5970) broke the use of a plain boolean filter. Add an overload similar to TypeScript’s Array#filter overload: https://github.com/microsoft/TypeScript/blob/v4.9.4/lib/lib.es5.d.ts#L1442-L1453 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
collection-filter-overload
branch
from
3448a0a to
6ae244d
Compare
kuanoni
added a commit
to kuanoni/astro-portfolio
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Commit dabce6b (#5970) broke the use of a plain boolean filter. Add an overload similar to TypeScript’s
Array#filteroverload.#5970 (comment) (cc @bholmesdev)
Testing
Tested with my company blog, which uses
const posts = await getCollection("posts", (post) => post.data.author === author).Docs
No documentation change needed.