Skip to content

Implement transition:persist-props#975

Merged
matthewp merged 2 commits intomainfrom
transition-persist-props
Mar 5, 2024
Merged

Implement transition:persist-props#975
matthewp merged 2 commits intomainfrom
transition-persist-props

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

@matthewp matthewp commented Mar 5, 2024

Changes

Testing

  • New test case added

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 8a696b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this directive intentionally not included in skippedAttributes and skippedAttributesToObject?

@matthewp
Copy link
Copy Markdown
Contributor Author

matthewp commented Mar 5, 2024

@martrapp It's renamed in the transform step, so it doesn't exist when it gets to the printer and doesn't need to be skipped.

@martrapp
Copy link
Copy Markdown
Member

martrapp commented Mar 5, 2024

Thought it would be the same for transition:persist but then I saw that there is one case were we append. ✔️

Copy link
Copy Markdown
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@matthewp matthewp merged commit 50fc0a9 into main Mar 5, 2024
@matthewp matthewp deleted the transition-persist-props branch March 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants