Skip to content

Move to shiki and stabilize dual themes support#6898

Merged
sarah11918 merged 4 commits into4.5.0from
back-to-shiki
Mar 8, 2024
Merged

Move to shiki and stabilize dual themes support#6898
sarah11918 merged 4 commits into4.5.0from
back-to-shiki

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Feb 15, 2024

Description (required)

Astro (withastro/astro#10130) moves back to shiki. shikiji has been merged into shiki 1.0, so we can use it back again.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.5. See astro PR withastro/astro#10130

@bluwy bluwy added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Feb 15, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 8, 2024 9:27pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Mar 8, 2024 9:27pm

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bluwy ! These links are so much nicer, too! 😄

@sarah11918 sarah11918 added this to the 4.5.0 milestone Feb 15, 2024
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @bluwy !

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants