Skip to content

fix: shorten Lambda Fn names to mitigate hitting length limit #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettstack merged 1 commit into from
Jun 10, 2020
Merged

fix: shorten Lambda Fn names to mitigate hitting length limit #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/delete-stack-on-pr-close.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ name: Delete preview stack on PR close

on:
pull_request:
types:
- closed
types: [closed]

jobs:
delete-stack:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: On Pull Request

on:
pull_request:
types: [synchronize, opened]
types: [synchronize, opened, reopened]

jobs:
auto-approve-dependabot:
Expand Down
16 changes: 8 additions & 8 deletions serverless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,10 @@ functions:
Resource:
- !GetAtt UserTable.Arn

cognitoAutoConfirm:
autoConfirmUser:
handler: packages/api/functions/cognito/auto-confirm-user.handler

cognitoPostAuthN:
postAuthN:
handler: packages/api/functions/cognito/post-authentication.handler
iamRoleStatements:
- Effect: "Allow"
Expand Down Expand Up @@ -226,8 +226,8 @@ resources:
# ReplyToEmailAddress: no-reply@halfstack.software
# SourceArn: arn:aws:ses:us-east-1:xxxx:identity/no-reply@halfstack.software
LambdaConfig:
PreSignUp: !GetAtt CognitoAutoConfirmLambdaFunction.Arn
PostAuthentication: !GetAtt CognitoPostAuthNLambdaFunction.Arn
PreSignUp: !GetAtt AutoConfirmUserLambdaFunction.Arn
PostAuthentication: !GetAtt PostAuthNLambdaFunction.Arn

CognitoUserPoolClient:
Type: AWS::Cognito::UserPoolClient
Expand All @@ -250,19 +250,19 @@ resources:
ProviderName: !GetAtt CognitoUserPool.ProviderName

# Allow Cognito to invoke the cognitoAutoConfirm and cognitoPostAuthN functions
CognitoAutoConfirmLambdaCognitoPermission:
AutoConfirmUserLambdaCognitoPermission:
Type: AWS::Lambda::Permission
Properties:
Action: lambda:InvokeFunction
FunctionName: !GetAtt CognitoAutoConfirmLambdaFunction.Arn
FunctionName: !GetAtt AutoConfirmUserLambdaFunction.Arn
Principal: cognito-idp.amazonaws.com
SourceArn: !GetAtt CognitoUserPool.Arn

CognitoPostAuthNLambdaCognitoPermission:
PostAuthNLambdaCognitoPermission:
Type: AWS::Lambda::Permission
Properties:
Action: lambda:InvokeFunction
FunctionName: !GetAtt CognitoPostAuthNLambdaFunction.Arn
FunctionName: !GetAtt PostAuthNLambdaFunction.Arn
Principal: cognito-idp.amazonaws.com
SourceArn: !GetAtt CognitoUserPool.Arn

Expand Down